Merged
Conversation
retrixe
requested changes
Oct 5, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
No dogs have spaces in their name, the arguments should always be joined, the only positive of doing it like this is that invalid commands like /dog shiba literally anything here works, but also incur a performance cost even valid usages.
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
approved these changes
Oct 5, 2020
Owner
retrixe
left a comment
retrixe
left a comment
There was a problem hiding this comment.
Well, the previous suggestions were pretty bad since I failed to notice there are sub-breeds, but this is a better iteration of those changes that have been reverted now, I suppose this is fine.
Co-authored-by: Ibrahim Ansari <retrixe@users.noreply.github.com>
retrixe
approved these changes
Oct 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #14
This was due to the API changing their 404 message. I also made it try joining the arguments if a sub breed isn't found, so that doing
/dog german shepherdis possible