Fix: ST1023: should omit type Err from declaration

[majst01]

Hi @gabor-boros

me again, had some spare time and spent it to fix some obvious linter complains.
Please have a look if your time allows.

Reason for the change
golangci-lint staticcheck complains that in variable declarations, the lefthand side is not necessary, fix this.

Description
A clear and concise description of what did you changed and why.

Code examples
If applicable, add code examples to help explain your changes.

Checklist

• I have read and agreed to the RethinkDB Contributor License Agreement

References
Anything else related to the change e.g. documentations, RFCs, etc.

[gabor-boros]

@majst01 Sorry, extremely late reply! I'm going to review the PR this week!

[majst01]

@majst01 Sorry, extremely late reply! I'm going to review the PR this week!

Hi @gabor-boros no worries :-)

[gabor-boros]

@majst01 I started reviewing the PR, but golangci-lint still shows many errors:

master branch

132 issues:
* errcheck: 37
* govet: 18
* ineffassign: 2
* staticcheck: 50
* unused: 25

this branch

114 issues:
* errcheck: 37
* govet: 18
* ineffassign: 2
* staticcheck: 32
* unused: 25

I was using golangci-lint has version 2.5.0 built with go1.25.1 from ff63786 on 2025-09-21T18:53:13Z.

---

Before going on, I wanted to check-in to see if you wanted to fix all staticcheck errors or only the unnecessary type annotations?

[majst01]

@majst01 I started reviewing the PR, but golangci-lint still shows many errors:

master branch

132 issues:
* errcheck: 37
* govet: 18
* ineffassign: 2
* staticcheck: 50
* unused: 25

this branch

114 issues:
* errcheck: 37
* govet: 18
* ineffassign: 2
* staticcheck: 32
* unused: 25

I was using golangci-lint has version 2.5.0 built with go1.25.1 from ff63786 on 2025-09-21T18:53:13Z.

Before going on, I wanted to check-in to see if you wanted to fix all staticcheck errors or only the unnecessary type annotations?

I started with a small list of same issues, otherwise the PR would be to big.