Skip to content

Cluster discovery & rare connection leak fixes #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 18, 2020
Merged

Cluster discovery & rare connection leak fixes #483

merged 21 commits into from
Mar 18, 2020

Conversation

CMogilko
Copy link
Member

No description provided.

@cquon
Copy link
Contributor

cquon commented Mar 19, 2020

Just as a clarifying question on this,

if there is an error processing response,
we close the channel (https://github.com/rethinkdb/rethinkdb-go/pull/483/files#diff-8f8a79f3f89c69a28dd878de98384cf9R289),
On the next pool query is this channel marked as bad already?
It seems like it is only being bad on the next time the channel tries to query and sees that it is closed.

Would this require client code to then query twice before that connection is marked as bad and it gets a new connection?

@CMogilko
Copy link
Member Author

CMogilko commented Mar 19, 2020

@cquon
Connection marked bad if any net.Conn Read() or Write() or protocol encoding returns error. It will be closed a bit later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants