Skip to content

External custom marshalers #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2018
Merged

External custom marshalers #446

merged 5 commits into from
Aug 29, 2018

Conversation

CMogilko
Copy link
Member

For case if you can't define MarshalRQL methods on structs.

@@ -9,7 +9,7 @@

![GoRethink Logo](https://raw.github.com/wiki/gorethink/gorethink/gopher-and-thinker-s.png "Golang Gopher and RethinkDB Thinker")

Current version: v4.0.0 (RethinkDB v2.3)
Current version: v4.1.0 (RethinkDB v2.3)

<!-- This project is no longer maintained, for more information see the [v3.0.0 release](https://github.com/gorethink/gorethink/releases/tag/v3.0.0)-->

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need this commented code?

}

type decoderCacheKey struct {
dt, st reflect.Type
blank bool
}

var decoderCache struct {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it OK to use global anonymous struct here?

@CMogilko CMogilko merged commit 64076e7 into master Aug 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants