Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix launching the CLI without access_control_allow_origin #604

Merged
merged 3 commits into from
Jun 17, 2016

Conversation

Tryneus
Copy link
Member

@Tryneus Tryneus commented Jun 16, 2016

The default behavior in the CLI was broken. Also added a warning message fixing #211.


This change is Reviewable

@Tryneus Tryneus added this to the Release 1.x.x milestone Jun 16, 2016
@deontologician
Copy link
Contributor

deontologician commented Jun 17, 2016

:lgtm: merging

@deontologician deontologician merged commit 90f0ab6 into next Jun 17, 2016
deontologician pushed a commit that referenced this pull request Jun 17, 2016
* fixed using an empty access_control_allow_origin

* added access_control_allow_origin='*' in dev mode

* adding warning message when using authentication without HTTPS
@deontologician
Copy link
Contributor

also cherry-picked to v1.x.x

@danielmewes danielmewes modified the milestones: Release 2.0, Release 1.x.x Aug 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants