Skip to content

Provide Task<IRestResponse<T>> methods #427

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 18, 2013
Merged

Conversation

haacked
Copy link
Contributor

@haacked haacked commented Sep 18, 2013

Also provided simpler extension methods when you don't care about the
response info and just want the data.

Fixes #423

Also provided simpler extension methods when you don't care about the
response info and just want the data.

Fixes #423
@half-ogre
Copy link

Seems reasonable. Having to put Task in every name sucks. Maybe {Operation}ResultAsync instead? (Yeah, I don't like it much either.)

:shipit:

@haacked
Copy link
Contributor Author

haacked commented Sep 18, 2013

Having to put Task in every name sucks

Yeah. It follows the standard guidelines when you already have the other obvious name GetFoo and GetFooAsync taken by existing methods. I'm going to follow the standard practice even if it's ugly so people know what to look for and expect. Thanks for the review!

haacked added a commit that referenced this pull request Sep 18, 2013
@haacked haacked merged commit d321bd5 into master Sep 18, 2013
@haacked haacked deleted the haacked/423-awaitable-async branch September 18, 2013 18:28
@half-ogre
Copy link

It follows the standard guidelines when you already have the other obvious name GetFoo and GetFooAsync taken by existing methods.

Good to know; I wasn't aware of that. Where does these standard guidelines live? I should probably read them.

@haacked
Copy link
Contributor Author

haacked commented Sep 18, 2013

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Awaitable async requests
2 participants