-
-
Notifications
You must be signed in to change notification settings - Fork 2.3k
Adding client-level cookie container #2042
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…dd cookies to the request headers
|
My concern would be adding the cookies to the container in the request because if the user is using a request specific container that they are maintaining, it means the client ones will end up in that container after the request. cookieContainer.Add(Options.CookieContainer.GetCookies(url)); Is it feasible to simply call headers.AddCookieHeaders(cookieContainer, url) for both cookie containers rather than combine them? |
|
Yeah, I thought about that as one of the options, but I haven't considered the request container concern. You are right, will change it now. |
Deploying with
|
| Latest commit: |
c121623
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://92532ab6.restsharp.pages.dev |
| Branch Preview URL: | https://client-level--cookies.restsharp.pages.dev |
|
@kendallb I updated it following your comment. |
|
Looks good to me |
RestClientOptions