Ignore Empty Uri Query Parameters

[Deantwo]

Description

A different attempt at fixing #1404 than what was proposed in #1408.
But even this is not a perfect solution, as explained in #1408 (comment) and #1408 (comment).

Someone with more knowhow should probably rewrite the entire ParseQuery(string) method. Or even better find a more standard way of doing it that doesn't require us to maintain the function ourselves.

For a good idea about how the query parsing should handle can be seen in this little article: https://zzzzbov.com/blag/query-string-hell

Purpose

This pull request is a: Bugfix (non-breaking change which fixes an issue)

[alexeyzimarev]

Thanks for the PR :)

I have one comment only - what is the motivation to provide an array with one element instead of using just a char as we did before?

[Deantwo]

what is the motivation to provide an array with one element instead of using just a char as we did before?

The system.string.split method only has one overload with params char[] as parameter. If you want to use any StringSplitOptions options, you have to supply it as a char[] array.

[alexeyzimarev]

I guess we need a test for this failure case too?

[Deantwo]

I guess we need a test for this failing case too?

As mentioned in #1408 (comment), there are still a few issues that this doesn't solve. But yes it would probably be a good idea to make some test cases based on the examples given in the https://zzzzbov.com/blag/query-string-hell article.

But it might be even better if the ParseQuery(string) method could be replaced with some built-in function or something. But I haven't had time to research that while at work, since fixing open-source bugs isn't all that good with my boss looking over my shoulder. I just find looking through the issues and making at least one bugfix a really good way to learn a new library.