Skip to content

Improved ServerServlet.createComponent() to address issue #766. #767

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Improved ServerServlet.createComponent() to address issue #766. #767

wants to merge 3 commits into from

Conversation

@arcticgeek
Copy link

No description provided.

@arcticgeek
Modified createComponent() so that ServerServlet can be used with cus…
b633400 
…tom Component subclass in mode 2, but retain the ability to configure it using restlet.xml as in mode 1. Added log output for clarity.
@arcticgeek
Modified createComponent() so that ServerServlet can be used with cus…
ced08a2 
…tom Component subclass in mode 2, but retain the ability to configure it using restlet.xml as in mode 1. Added log output for clarity. These changes address issue restlet#766.
@arcticgeek
Merge branch 'servlet-extension-improvements' of https://github.com/a…
66d11be 
…rcticgeek/restlet-framework-java into servlet-extension-improvements
@arcticgeek
Copy link
Author

These changes are completely backward compatible with existing versions of the servlet extension.
I am currently working with Restlet v2.1.2 and I hope that my improvement can be merged for v2.1.3,

@ghost ghost assigned thboileau Nov 15, 2013
@thboileau
Copy link
Contributor

I'll merge this with the future Restlet 2.1.5.

@jlouvel jlouvel closed this Feb 6, 2014
@jlouvel
Copy link
Collaborator

jlouvel commented Feb 6, 2014

Closed by error

@jlouvel jlouvel reopened this Feb 6, 2014
@jlouvel jlouvel modified the milestones: Unplanned issues, 2.1.5, 2.1.7, Unplanned Feb 6, 2014
@jlouvel jlouvel modified the milestones: 2.2 RC1, 2.1.7 Feb 7, 2014
@jlouvel
Copy link
Collaborator

jlouvel commented Feb 7, 2014

Set milestone to 2.2 RC1 due this week-end as it is not strictly a bug fixing but an enhancement.

2.2 will soon become our "stable" release, so anyway it will be recommmended to migrate in production.

@arcticgeek
Copy link
Author

Sounds great and thanks again.
J

On Fri, Feb 7, 2014 at 9:01 AM, Jerome Louvel notifications@github.comwrote:

Set milestone to 2.2 RC1 due this week-end as it is not strictly a bug
fixing but an enhancement.

2.2 will soon become our "stable" release, so anyway it will be
recommmended to migrate in production.

Reply to this email directly or view it on GitHubhttps://github.com//pull/767#issuecomment-34481477
.

907-360-1405

thboileau pushed a commit that referenced this pull request Feb 8, 2014
Improved ServerServlet.createComponent() to address issues #766 and #767
a02f50a 
: allowed to specify a custom Component class and configure it using xml file. Reported and contributed by arcticgeek.
@thboileau
Copy link
Contributor

Many thanks articgeek for your contribution and patience! It is now part of Restlet Framework 2.2 branch.

@thboileau thboileau closed this Feb 8, 2014
@jlouvel
Copy link
Collaborator

jlouvel commented Feb 8, 2014

@arcticgeek We forgot to ask you to sign the Joint Copyright Assignment document (PDF at http://restlet.org/participate/jca).

Could you return us a signed version scanned by email at legal@restlet.com?

See this page for details:
http://restlet.org/participate/contribute#submit-contribution

@jlouvel jlouvel reopened this Feb 8, 2014
@thboileau thboileau closed this Feb 9, 2014
@thboileau
Copy link
Contributor

Jca received, thanks arcticgeek.

@thboileau thboileau mentioned this pull request Mar 26, 2014
Closed
@caleryn caleryn mentioned this pull request Jun 30, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@thboileau thboileau

Labels

Priority: medium State: implementation Type: enhancement Version: 2.1

Projects

None yet

Milestone

2.2 RC1

Development

Successfully merging this pull request may close these issues.

3 participants

@arcticgeek @thboileau @jlouvel