Fix bug in OAUTH extension #619
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code that handles the response expects JSON, so we make sure to set the type to JSON in the ACCEPT header. This makes the code work with github OAUTH: http://developer.github.com/v3/oauth/.
|
Tom thanks for this. I will just verify this against some other OAuth sites so that it does not break anything. But it looks to me that it is perfectly fine. |
ghost
assigned
|
Any update? Also, I noticed that there is no way to include the optional "state" parameter. Do you have plans to add this? |
|
Tom, could you check the fix against another OAuth site in addition to GitHub? |
|
I verified that this works with Google OAUTH. |
stoffeg
added a commit
that referenced
this pull request
Aug 22, 2012
Adds Accept header to prefer json content back from a auth server
|
Thanks Tom, just merged, will also try to merge it to the 2.1 later on today with other things. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code that handles the response expects JSON, so we make sure to set
the type to JSON in the ACCEPT header. This makes the code work with
github OAUTH: http://developer.github.com/v3/oauth/.