Add Overload to OAuthParameters.toReference which Accepts an Existing Reference #1240
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevent unpacking and repacking of reference instances when adding client query information from OAuthParameters by providing a call to apply the query to an existing reference
|
many thanks for your contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent unpacking and repacking of reference instances when adding client query information from OAuthParameters by providing a call to apply the query to an existing reference.
When using the existing APIs, I found that a common pattern emerged where a Reference was present, but had to be serialized and deserialized to and from a String in order to add OAuth query parameters. If the OAuthParameters instance offered a toReference call which took a reference object, this pattern could be simplified for clients.