StatusService#toStatus(Status,Resource) should be defined in terms of other #toStatus

[Tembrel]

Currently both toStatus variants of StatusService are defined in terms of their corresponding (deprecated) getStatus equivalents, and getStatus(Status, Resource) is defined in terms of getStatus(Status, Request, Response). If toStatus(Status, Resource) were defined in terms of toStatus(Status, Request, Response), instead of getStatus(Status, Resource), then it would only be necessary to override one variant of toStatus.

[thboileau]

Hello Tim,

I may be wrong, but I guess the intention was to wrap the newly deprecated methods getStatus(*) method, in case users have their own implementations of these methods.
If we implement toStatus(Throwable, Resource) by calling toStatus(Throwable, Request, Response), the overriden getStatus(Throwable, Resource) won't be called.
In 3.0, the getStatus(*) will be removed.
Does this give more explanation?

[Tembrel]

You're not wrong, it's just that until getStatus(*) is removed, anyone overriding toStatus(Status, Request, Response) must also override toStatus(Status, Resource). It's not hard to do, it's just that you have to know to do it.

Maybe the right move is to keep things as they are in 2.x, and to add a note saying what the default implementation of each toStatus is, and that it might be necessary to override both variants of the method.