Bug in Representation ClientResource.get(MediaType mediaType)

[dscoppelletti]

If you run the following code:

Reference url = ...
ClientResource client = new ClientResource(url);
client.accept(Language.ENGLISH_US);
client.get(MediaType.APPLICATION_JSON);

The language header is ignored.
This is because of the following overload in the class ClientResource:

protected Representation handle(Method method, Representation entity, MediaType mediaType) {
    return handle(method, entity, new ClientInfo(mediaType));
}

As you can see, the handle method uses a new instance of the ClientInfo object, thus all the properties of the ClientInfo object you can set before are ignored!

Of course, now I am using the following code and it runs properly:

Reference url = ...
ClientResource client = new ClientResource(url);
client.accept(Language.ENGLISH_US);
client.accept(MediaType.APPLICATION_JSON);
client.get();

But I had to dig for discovering this.

[thboileau]

Thanks @dscoppelletti for reporting this.
We can handle this issue as follow:

• either update the javadocs in order to tell that the client preferences are reset
• or update the code by taking care of existing preferences, and set the given media type as the first preferred media type.

I think I prefer the latter. do you?

[dscoppelletti]

Yes, I prefer the latter, too.
Even better if you can clone the ClientInfo object and set the MediaType in the clone as the only one MediaType; so that the original client preferences remain unchanged as JavaDoc says for the ClientResource.get(MediaType) method overload.