Skip to content

Merge send methods and rename with in bind #263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
slinkydeveloper merged 2 commits into from
Mar 25, 2024
Merged

Merge send methods and rename with in bind #263

slinkydeveloper merged 2 commits into from
Mar 25, 2024

Conversation

@slinkydeveloper
Copy link
Contributor

@slinkydeveloper slinkydeveloper commented Mar 25, 2024

Fix #260, fix #262

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Test Results

0 files   -  92  0 suites   - 92   0s ⏱️ - 5m 38s
0 tests  -  79  0 ✅  -  74  0 💤  -  5  0 ❌ ±0 
0 runs   - 205  0 ✅  - 190  0 💤  - 15  0 ❌ ±0 

Results for commit 828d131. ± Comparison against base commit 62e45c1.

@github-actions
Copy link
Contributor

github-actions bot commented Mar 25, 2024

Unit Test Results

555 tests   - 69   548 ✔️  - 64   9s ⏱️ - 1m 53s
  13 suites  - 31       7 💤  -   5 
  13 files    - 31       0 ❌ ±  0 

Results for commit 828d131. ± Comparison against base commit 62e45c1.

igalshilman
igalshilman approved these changes Mar 25, 2024
View reviewed changes
Copy link
Contributor

@igalshilman igalshilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@slinkydeveloper slinkydeveloper merged commit f2bc8ba into main Mar 25, 2024
@slinkydeveloper slinkydeveloper deleted the issues/260_and_262 branch March 25, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@igalshilman igalshilman igalshilman approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Combine send/sendDelayed in a single send method with override Rename endpoint builders' with in bind

3 participants

@slinkydeveloper @igalshilman