[Bifrost][Minor] Improves logging and reporting of status on append failures#4458
Open
AhmedSoliman wants to merge 3 commits intomainfrom
Open
[Bifrost][Minor] Improves logging and reporting of status on append failures#4458AhmedSoliman wants to merge 3 commits intomainfrom
AhmedSoliman wants to merge 3 commits intomainfrom
Conversation
This was referenced Mar 4, 2026
Test Results 7 files 7 suites 4m 40s ⏱️ Results for commit dffbf6c. ♻️ This comment has been updated with latest results. |
muhamadazmy
approved these changes
Mar 9, 2026
This was referenced Mar 9, 2026
Extract two generic, reusable utilities into restate-futures-util: **monotonic_token**: A lightweight mechanism for a producer to signal completion of a prefix of sequentially issued work items. Provides Token<T>, TokenOwner<T>, Tokens<T>, and TokenListener<T> types with a phantom type parameter to prevent mixing tokens from different domains. Uses atomics (Relaxed/Release/Acquire) for lock-free operation — no RwLock or watch overhead. **waiter_queue**: A priority-drainable queue (WaiterQueue<K, V>) designed for the common case where entries arrive in key-order. Uses an adaptive strategy: push_back for in-order inserts (O(1)), binary-search insert for out-of-order (rare). Drain is always a simple front-pop. Includes a Criterion benchmark comparing four strategies (naive, compact, adaptive, sorted-insert). Both modules include comprehensive documentation and tests. Neither references any specific use-case — they are general-purpose building blocks.
This was referenced Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.