Invocation Pause RPC command requires protocol version V3 #4251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@slinkydeveloper Are you aware of any changes in the RPC command that requires wire protocol version V3 ? |
Contributor
Pause should work fine on 1.5 too? |
Contributor
I don't know about the details of wire protocol, but i don't think we changed this command at all in this release, right? |
Contributor
Author
|
@slinkydeveloper Not really. The RPC (manual) Pause command did not exist in v1.5.x and this caused the node to panic on decoding the rpc message. |
Contributor
|
Ahhhhh right we're talking about RPC, not wal commands, then yes Pause did not exist in 1.5, sorry for the mistake |
Summary: Make sure that nodes with V1.5 don't crash when receiving an unknown rpc command
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Invocation Pause RPC command requires protocol version V3
Summary:
Make sure that nodes with V1.5 don't crash when receiving an unknown
rpc command