Add info to deployment/service/handler #3923
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…me configuration errors/warnings, such as when values are clamped or ignored.
slinkydeveloper
commented
Oct 23, 2025
| info.push( | ||
| Info::new_with_code( | ||
| &restate_errors::RT0021, | ||
| format!("The configured inactivity_timeout {} will not be applied because the handler is exposed in Request/Response mode.", FriendlyDuration::new(inactivity_timeout)) |
slinkydeveloper
commented
Oct 23, 2025
| if got_journal_retention_clamped { | ||
| info.push(Info::new_with_code( | ||
| &restate_errors::RT0022, | ||
| "The configured journal_retention is clamped to the maximum cluster limit." |
nikrooz
approved these changes
Oct 23, 2025
Contributor
nikrooz
left a comment
nikrooz
left a comment
There was a problem hiding this comment.
thx, lgtm. Maybe "Restate Server" instead of "Cluster" might be more consistent with what we have in docs.
Make sure we return the info in deployment responses too
slinkydeveloper
deleted the
warning-request-response-inactivity-timeout
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is meant to propagate some configuration errors/warnings, such as when values are clamped or ignored.
@nikrooz can you review the error messages?