Add deduplication layer to deduplicate shuffle messages #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Once this PR is merged, we should be able to re-enable the persistence e2e tests again. |
This commits extends the DedupLayer to deduplicate messages coming from other shuffle components. This is important because the shuffle components might resend persisted messages on a restart even though they have already been received (e.g. if the truncation has not happened yet before the restart). This fixes #147. Rename DedupLayer into DeduplicatingStateMachine and move under state_machine module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces the
DeduplicatingStateMachineto deduplicate messages coming from shuffle components. This is important because the shuffle components might resend persisted messages on a restart even though they have already been received (e.g. if the truncation has not happened yet before the restart).This fixes #147.