Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update release checklist doc #1930

Merged
merged 3 commits into from
Sep 10, 2024
Merged

Update release checklist doc #1930

merged 3 commits into from
Sep 10, 2024

Conversation

pcholakov
Copy link
Contributor

Minor tidy-up:

  • remove SDK release requirement
  • add explicit service protocol release requirement

- remove SDK release requirement
- add explicit service protocol release requirement
README.md Outdated

* [SDK-Java](https://github.com/restatedev/sdk-java/?tab=readme-ov-file#versions)
* [SDK-Typescript](https://github.com/restatedev/sdk-typescript/?tab=readme-ov-file#versions)
* [SDK-TypeScript](https://github.com/restatedev/sdk-typescript/?tab=readme-ov-file#versions)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add all the other SDK links too

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

@@ -108,10 +108,10 @@ Restate follows [Semantic Versioning](https://semver.org/).

You can safely upgrade from a Restate `x.y` to `x.(y+1)` release without performing any manual data migration, as Restate performs an automatic data migration for you.

To check the compatibility with the SDKs, check the respective READMEs:
For SDK compatibility, refer to the supported version matrix in the respective READMEs:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps generally, what I would write here is something along the lines of "get in touch with the respective SDK owners to check whether a new release should be made for the SDKs"

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done!

Copy link

github-actions bot commented Sep 6, 2024

Test Results

15 files  ±0  15 suites  ±0   19m 50s ⏱️ +21s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
18 runs  ±0  18 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 990a7ad. ± Comparison against base commit 264addd.

♻️ This comment has been updated with latest results.

@@ -30,6 +30,8 @@ https://github.com/issues?q=is%3Aopen+org%3Arestatedev+label%3Arelease-blocker

Make sure that all [supported service protocol versions](../../crates/types/src/service_protocol.rs) are released.

Confirm if any SDK releases are needed to keep up with the runtime and/or service protocol releases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perfect!

@pcholakov pcholakov merged commit 9a48f3d into main Sep 10, 2024
10 checks passed
@pcholakov pcholakov deleted the chore/update-release-checklist branch September 10, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants