Side effect retry mechanism #1893
Conversation
|
Related sdk-shared-core PR: restatedev/sdk-shared-core#7 and sdk-rust PR: restatedev/sdk-rust#20 |
|
Seems like this PR uncovered an issue with version negotiation in typescript, looking at it now... |
|
The integration test posted here restatedev/sdk-test-suite#10 passes with the pending Rust SDK branch, so all looks good. |
|
Fix for typescript: restatedev/sdk-typescript#418 |
slinkydeveloper
force-pushed
the
issues/1449
branch
2 times, most recently
from
011e962 to
01d2cc5
Compare
tillrohrmann
left a comment
tillrohrmann
left a comment
There was a problem hiding this comment.
Thanks for implementing a mechanism to implement flexible retry strategies on the SDK side @slinkydeveloper. The changes look good to me. I only had a few minor comments. +1 for merging after resolving them.
crates/types/service-protocol/dev/restate/service/protocol.proto
Outdated
Show resolved
Hide resolved
| const SERVICE_PROTOCOL_VERSION_V2: HeaderValue = | ||
| HeaderValue::from_static("application/vnd.restate.invocation.v2"); |
There was a problem hiding this comment.
We did introduce this new service protocol version to prevent a new SDK from connecting to an old server and assuming that the new retry policy is working but in reality it is not, right?
…5aad2b 0d35aad2b Add fields for the Side effect retry feature (restatedev#95) 89224c68f Add buf configuration git-subtree-dir: crates/types/service-protocol git-subtree-split: 0d35aad2b295687cbbfebfe6becfda052f1fee9d
* Introduce Protocol Version V2 * Also adds a workaround to make sure typescript SDK <= 1.2.1 works with Restate 1.1
slinkydeveloper
force-pushed
the
issues/1449
branch
from
7d6bbb6 to
a1f3c9d
Compare
2 participants
Fix #1449
We currently don't have any e2e tests for this, I've tested it locally though and it works. I'll add the integration tests as next step