[Bifrost] Basic BifrostAdmin interface #1753
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 25, 2024
tillrohrmann
approved these changes
Jul 26, 2024
Comment on lines
+176
to
+177
| /// Deletes the key-value pair for the given key following the provided precondition. If the | ||
| /// precondition is not met, then the operation returns a [`WriteError::PreconditionViolation`]. |
There was a problem hiding this comment.
Thanks for adding these Rustdocs 🙏
Loglet wrapper now limits reads if the loglet sealed tail is known
This introduces a new read stream implementation that operates under a multi-segment bifrost world. Notable features include: - Support for reading from multiple segments seamlessly - Reading unsealed segments while watching the tail state to determine the safe boundaries with minimal efficiency loss - Handling of on-going reconfiguration, the stream waits for the loglet to be sealed. - Handles prefix trims on metadata-level when detected (partial support, more on that in follow up PRs) Running bifrost-benchpress read-to-write latency tests show that the new read-stream doesn't introduce any meaningful regression in latency in the the unsealed close-to-tail case (note that P100 should be discarded due to shutdown-related noise) Write-to-read latency: ``` New Old Total records read: 98317 Total records read: 97871 P50: 67.455µs P50: 67.519µs P90: 77.951µs P90: 77.183µs P99: 96.447µs P99: 94.143µs P999: 129.215µs P999: 122.815µs ```
This allows correct handling of sealing empty loglets and support for future reconfiguration operations.
It now hosts `trim` and introduces the ability to seal and extend the chain with a pre-determined loglet params
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Bifrost] Basic BifrostAdmin interface
It now hosts
trimand introduces the ability to seal and extend the chain with a pre-determined loglet paramsStack created with Sapling. Best reviewed with ReviewStack.