Update aws deps in service-client #1734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackkleeman
force-pushed
the
update-aws-deps
branch
from
ed382b1 to
0ceebe3
Compare
|
NB to myself: test before merging |
jackkleeman
force-pushed
the
update-aws-deps
branch
from
0ceebe3 to
ed382b1
Compare
jackkleeman
force-pushed
the
update-aws-deps
branch
from
ed382b1 to
9c7280e
Compare
slinkydeveloper
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
LGTM, so unfortunate we need to copy that code...
Can you link smithy-lang/smithy-rs#3769 in aws_hyper_client.rs?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Have to unfortunately inline the hyper 1.0 client pending smithy-lang/smithy-rs#3769
Fixes #1729