Schemas -> Live<Schema> #1671
Merged
Schemas -> Live<Schema> #1671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 27, 2024
tillrohrmann
approved these changes
Jun 28, 2024
- Automatic caching and redesigned interface - Nodes configuration is not optional anymore. Node configuration is empty with an INVALID version before loading. - Updateable<T> provides a readonly live view of an updateable. Namely, it hides all access to the underlying ArcSwap. - Use updateable config in networking and avoid metadata() - Efficient access to metadata and nodes configuration in performance-sensitive networking code - Easy to map and around as owned types - Supports projections and type erasure
This changes how we pass Schema around, instead of implying being updateable, we invert control to allow users to decide when and how to look at a consistent snapshot of the schema.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Schemas -> Live
This changes how we pass Schema around, instead of implying being updateable, we invert control to allow users to decide when and how to look at a consistent snapshot of the schema.
Stack created with Sapling. Best reviewed with ReviewStack.