Only emit admin API incompatibility warning if cluster is running #1659
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AhmedSoliman
approved these changes
Jun 25, 2024
| @@ -68,6 +68,7 @@ macro_rules! define_primitive_trait { | |||
| }; | |||
| } | |||
|
|
|||
| #[cfg(feature = "table_docs")] | |||
There was a problem hiding this comment.
Nice. I guess that fixes a warning that surfaced after upgrading the toolchain.
tillrohrmann
force-pushed
the
issues/1646
branch
from
a563e67 to
d26fb87
Compare
This commit changes when the CLI prints an admin API incompatibility warning. The warning is now printed if the admin API version couldn't be validated and if the cluster is reachable (via checking the /health endpoint). If the cluster is not reachable, then the CLI terminates with an error message stating that the Restate server is not reachable. This fixes restatedev#1646.
tillrohrmann
force-pushed
the
issues/1646
branch
from
d26fb87 to
38b03d5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit changes when the CLI prints an admin API incompatibility
warning. The warning is now printed if the admin API version couldn't
be validated and if the cluster is reachable (via checking the /health
endpoint). If the cluster is not reachable, then the CLI terminates with
an error message stating that the Restate server is not reachable.
This fixes #1646.