[Housekeeping] Upgrade toolchain and deps #1645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 19, 2024
Merged
Merged
AhmedSoliman
force-pushed
the
pr1645
branch
2 times, most recently
from
1b5fba2 to
432de98
Compare
AhmedSoliman
force-pushed
the
pr1645
branch
3 times, most recently
from
f11590b to
964b71e
Compare
AhmedSoliman
force-pushed
the
pr1645
branch
3 times, most recently
from
ebb9c00 to
2d91b67
Compare
AhmedSoliman
force-pushed
the
pr1645
branch
3 times, most recently
from
3964831 to
1bd5a78
Compare
tillrohrmann
approved these changes
Jun 24, 2024
There was a problem hiding this comment.
Thanks for the housekeeping @AhmedSoliman! The one question I had is whether we also need to add version = 2 to [licenses] in order to enable the new default values. +1 for merging after sorting this out.
| @@ -209,6 +209,7 @@ fn validate_and_update_cluster_marker_inner( | |||
| // write the new cluster marker file | |||
| let new_cluster_marker_file = OpenOptions::new() | |||
| .create(true) | |||
| .truncate(true) | |||
There was a problem hiding this comment.
Thanks for catching this bug!
| @@ -1,4 +1,4 @@ | |||
| [toolchain] | |||
| channel = "1.75.0" | |||
| channel = "1.79.0" | |||
There was a problem hiding this comment.
I'll update our dev-tools docker image accordingly.
- Remove schema/schema-api (now in `restate_types::schema`) - Remove cluster-controller and merge with restate-admin - Use `prost-dto` for cluster-state - Move networking types to `restate_types::net` - Protobuf internal types reorg
- Merge `restate-network` into `restate-core` - Merge NetworkError and NetworkSendError
- Upgrade rocksdb - Upgrade Rust toolchain to 1.79.0 - Remove unused functions that new clippy complains about (including get_next_message in shuffle that we stopped using recently)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Housekeeping] Upgrade toolchain and deps
Stack created with Sapling. Best reviewed with ReviewStack.