[CLI] Bootstrapping restatectl admin command line #1625
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looping in @jackkleeman for cloud commands |
jackkleeman
approved these changes
Jun 13, 2024
tillrohrmann
approved these changes
Jun 14, 2024
Comment on lines
+127
to
+128
| /// Sets the global context to the given value. In general, this should be called once on CLI | ||
| /// initialization. |
There was a problem hiding this comment.
Could this be enforced by not using an ArcSwap in the GLOBAL_CLI_CONTEXT and instead directly storing the CliContext? Or do we need the ArcSwap for testing scenarios where one wants to update the CliContext?
There was a problem hiding this comment.
That's the intention, although we don't actually have tests that exercise that now.
Note: This PR contains mechanical changes, but to help reviewers, here are the most important changes: - Introduces new stubbed `restatectl` CLI that will be host debugging commands. The tool is meant to be used by operators with direct access to Restate clusters. - Introduce `restate-cli-util` hosting shared utilities and a decent portion of UI rendering tools from `restate` cli. This is to allow sharing the logic across CLIs. - Introduce `CliContext`. A global that gets configured by `CommonOpts` clap structure. This makes it easy to change output styling, logging, datetime formats across CLI utilities without threading through an environment object. - `CliContext` in conjunction with `CommonOpts` allow for sharing common top-level command line options between our CLIs (e.g. `--yes`, `--table-style`, etc.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[CLI] Bootstrapping restatectl admin command line
Note: This PR contains mechanical changes, but to help reviewers, here are the most important changes:
restatectlCLI that will be host debugging commands. The tool is meant to be used by operators with direct access to Restate clusters.restate-cli-utilhosting shared utilities and a decent portion of UI rendering tools fromrestatecli. This is to allow sharing the logic across CLIs.CliContext. A global that gets configured byCommonOptsclap structure. This makes it easy to change output styling, logging, datetime formats across CLI utilities without threading through an environment object.CliContextin conjunction withCommonOptsallow for sharing common top-level command line options between our CLIs (e.g.--yes,--table-style, etc.)