Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing unnecessary chdir #1473

Merged
merged 1 commit into from
Apr 26, 2024
Merged

Removing unnecessary chdir #1473

merged 1 commit into from
Apr 26, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Apr 26, 2024 •
edited
Loading

Removing unnecessary chdir

Closes #1471

@AhmedSoliman AhmedSoliman mentioned this pull request Apr 26, 2024
Closed
@AhmedSoliman AhmedSoliman self-assigned this Apr 26, 2024
@github-actions GitHub Actions
Copy link

Test Results

 95 files   95 suites   7m 54s ⏱️
 82 tests  80 ✅ 2 💤 0 ❌
212 runs  206 ✅ 6 💤 0 ❌

Results for commit f40446d.

tillrohrmann
tillrohrmann approved these changes Apr 26, 2024
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@AhmedSoliman AhmedSoliman merged commit 5a826ce into main Apr 26, 2024
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1473 branch April 26, 2024 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackkleeman jackkleeman jackkleeman approved these changes

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees

@AhmedSoliman AhmedSoliman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug with configuration change dir and signing key loading
3 participants
@AhmedSoliman @tillrohrmann @jackkleeman