feat: Optionally serve OAuth 2.0 authentication with HTTPS#38
Draft
gdavison wants to merge 1 commit intorest-sh:mainfrom
Draft
feat: Optionally serve OAuth 2.0 authentication with HTTPS#38gdavison wants to merge 1 commit intorest-sh:mainfrom
gdavison wants to merge 1 commit intorest-sh:mainfrom
Conversation
95689eb to
1bc41bd
Compare
Collaborator
|
Very interesting! I wonder if things could "just work" if we generate a real cert that browsers would accept and make local.rest.sh (or something similar) resolve to localhost. Any other ideas about how best to make this as painless as possible? |
|
mkcert makes creating localhost certs very easy https://github.com/FiloSottile/mkcert |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Looking for feedback on the approach I've taken.
This PR adds the option to serve an OAuth 2.0 Authorization Code workflow with HTTPS in addition to HTTP. This is required by some APIs that don't allow HTTP for the auth page.
Currently works with a certificate file named
localhost.crtand private key file namedlocalhost.keyin the configuration directory. These files must be created manually, for example usingopenssl.Questions:
To do:
Closes #31