Remove Parabolic and Hyperbolic mirror restrictions #469
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Probably the methods documentation should be updated to avoid the word optical |
for more information, see https://pre-commit.ci
jgalan
approved these changes
Feb 22, 2024
Vindaar
reviewed
Feb 22, 2024
| TVector3 GetHyperbolicVectorIntersection(const TVector3& pos, const TVector3& dir, const Double_t alpha, | ||
| const Double_t R3, const Double_t lMirr, const Double_t focal) { | ||
| const Double_t R3, const Double_t focal) { | ||
| Double_t beta = 3 * alpha; |
Member
There was a problem hiding this comment.
This line, as mentioned in the other PR.
Vindaar
approved these changes
Feb 22, 2024
Member
Vindaar
left a comment
Vindaar
left a comment
There was a problem hiding this comment.
Feel free to ignore my comment about the definition of α, if you wish.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is makes the true Wolter optics infinite in both +z and -z direction so that the length can be set only in the library where it is used. This way, the mirror length could be removed from the parabolic and hyperbolic intersection calculations.
Also some commentation updates.
This PR is associated with PR `https://github.com/rest-for-physics/axionlib/pull/81