-
Notifications
You must be signed in to change notification settings - Fork 13
New class TRestDataSetPlot to perform plots over datasets #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…TRestAnalysisPlot
jgalan
reviewed
May 1, 2023
jgalan
reviewed
May 1, 2023
jgalan
approved these changes
May 1, 2023
Co-authored-by: Javier Galan <javier.galan@unizar.es>
lobis
reviewed
May 2, 2023
lobis
reviewed
May 2, 2023
lobis
reviewed
May 2, 2023
lobis
reviewed
May 2, 2023
lobis
reviewed
May 2, 2023
lobis
reviewed
May 2, 2023
…n of the unique_ptr Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
Co-authored-by: Luis Antonio Obis Aparicio <35803280+lobis@users.noreply.github.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
Member
|
@juanangp it would be good to have a RML example. Inside the directory https://github.com/rest-for-physics/framework/tree/master/examples |
Member
Author
Done |
lobis
approved these changes
Jun 5, 2023
Member
|
@juanangp Should be merged already? |
Member
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New class
TRestDataSetPlotimplemented which is meant to perform plots over aTRestDataSetand it is meant to replaceTRestAnalysisPlot.Summary of the changes:
TRestDataSetPlotmetadata similar toTRestAnalysisPlotwith with some minor modifications.TRestCutSetDataSettoSetDataFrameinTRestDataSetsince the first one is misleading.quantityonTRestDataSetfromDouble_ttostringsince it is stored asstringin theTRestRunmetadataREST_StringHelper::GetCharfunction since it was causing segfault