Skip to content

Conversation

@lobis
Copy link
Member

@lobis lobis commented Feb 10, 2023

lobis Ok: 46

This PR:

  • Adds a new script to verify the files related to pre-commit from the submodules match the ones in the framework repository. This script should be run from the submodule root repository and will be included into the CI, this way we only need to maintain the pre-commit configuration in the framework repository.
  • Remove the old implementation of pre-commit git hooks.
  • Remove the redundant workflow step to run the pre-commit check, since this is already done via the webhook. This will fix the current problem in Rounding AddPoint input rawlib#95.

A separate PR for each submodule will need to be implemented (#374).

@lobis lobis requested review from jgalan and juanangp February 10, 2023 10:56
@lobis lobis added bug Something isn't working policy How things should behave style Related to code styling labels Feb 10, 2023
@lobis lobis marked this pull request as ready for review February 10, 2023 10:57
@lobis lobis merged commit 3561df7 into master Feb 10, 2023
@lobis lobis deleted the lobis-pre-commit-submodules branch February 10, 2023 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working policy How things should behave style Related to code styling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants