TRestMetadata documentation revision #328
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgalan
requested review from
KonradAltenmueller,
cmargalejo,
juanangp,
lobis and
nkx111
juanangp
approved these changes
Nov 15, 2022
Member
|
I added a minor commit (c63e660) to remove a misplaced print in the cmake, in order to avoid creating a PR for this. |
Member
Author
|
Plz, approve, just a documentation update |
KonradAltenmueller
approved these changes
Nov 17, 2022
Member
You should address the suggestion before merging though! (its not just a documentation update, it changes the cmake too). |
lobis
requested changes
Nov 17, 2022
Member
lobis
left a comment
lobis
left a comment
There was a problem hiding this comment.
cmake change should be either removed (since this is just a documentation update) or atleast explained before merging.
lobis
approved these changes
Nov 18, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I just updated the globals section to match my present user experience with
constantandvariable, which did not correspond with what it was written in the documentation.Perhaps it requires a bit of revision, please, check and update the modified parts if needed.