Skip to content

Conversation

@nkx111
Copy link
Member

@nkx111 nkx111 commented Jul 26, 2022

nkx111 Medium: 148

Added event selection bar at bottom to quickly jump events. No need to manually input event id anymore. The selection is applied on AnalysisTree observables through TTreeFormula.

image

@nkx111 nkx111 requested review from jgalan and lobis July 26, 2022 13:21
@nkx111 nkx111 requested a review from a team July 27, 2022 07:11
@jgalan
Copy link
Member

jgalan commented Jul 27, 2022

Interesting the TTreeFormula I guess the method Bool_t TRestAnalysisTree::EvaluateCut(const string cut) could be improved and simplified using that?

@jgalan
Copy link
Member

jgalan commented Jul 27, 2022

On the other hand, there is any difference between --, ++ and Previous Event Next Event? I imagine -- and ++ operates on single signals? single hits? single tracks?

@nkx111
Copy link
Member Author

nkx111 commented Jul 27, 2022

On the other hand, there is any difference between --, ++ and Previous Event Next Event? I imagine -- and ++ operates on single signals? single hits? single tracks?

Yes, ++, -- means to switch between signals. It could be possible to switch other sub-items inside the event, if we further implement the plot methods for track event or hits event.

@nkx111
Copy link
Member Author

nkx111 commented Jul 27, 2022

Interesting the TTreeFormula I guess the method Bool_t TRestAnalysisTree::EvaluateCut(const string cut) could be improved and simplified using that?

Yes, it is possible. Using ROOT native methods/classes shall always be better.

@jgalan jgalan requested a review from a team July 28, 2022 07:35
@jgalan
Copy link
Member

jgalan commented Jul 29, 2022

Approuve plz!

@nkx111 nkx111 merged commit 3598d3c into master Aug 7, 2022
@nkx111 nkx111 deleted the nkx111-patch-5 branch August 7, 2022 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants