Adding new Angle unit
#221
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…I naming convention)
…tion of 'degrees' with static storage duration may throw an exception that cannot be caught`
…ved `constexpr` from one macro to fix compilation problem.
juanangp
reviewed
May 23, 2022
Member
|
Most of the pipelines are failing, do you understand why? |
Member
Author
No, but hopefully it gets fixed by merging master intro this branch, as it looks like it has to do with submodules. |
juanangp
approved these changes
May 25, 2022
glorialuzon
approved these changes
May 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new unit to measure angles. Previously they were defined only in radians.
Radians is still the default unit, but now
degordegree(s)can also be used. I also addedradandradian(s)as units in case anyone wants to be more explicit with the unit.I will also updated some examples on
restG4to make use of this unit so that they are easier to understand.Angleunit geant4lib#48<filesystem>to improve prints, updating examples with newdegangular unit restG4#46