Skip to content

Conversation

@omarqureshi
Copy link

No description provided.

@kiyanwang
Copy link

What happens if the id is not set? i think we saw yesterday that payload['id'] is set by the php-resque framework but not by ruby / node ... does this take that into account?

@omarqureshi
Copy link
Author

Nil.to string is the empty string. So should be ok

On 23 Sep 2016 7:10 a.m., "Nadeem Shabir" notifications@github.com wrote:

What happens if the id is not set? i think we saw yesterday that
payload['id'] is set by the php-resque framework but not by ruby / node ...
does this take that into account?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#120 (comment), or mute
the thread
https://github.com/notifications/unsubscribe-auth/AACJnTBChaGCZb_ELXbUnkANmwn7Zdbtks5qs21HgaJpZM4KD_Dg
.

@kiyanwang
Copy link

Nil.to string is the empty string. So should be ok

awesome

👍

@kirillplatonov kirillplatonov changed the base branch from master to add_job_id_to_failure_and_queue_show_page May 26, 2017 07:31
@kirillplatonov kirillplatonov merged commit 93f95c2 into resque:add_job_id_to_failure_and_queue_show_page May 26, 2017
@kirillplatonov
Copy link

@omarqureshi thanks for your PR. Nice job! It's merged in master now and I will release it with new version soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants