Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a notification component #1313

Merged
merged 3 commits into from
Oct 6, 2024
Merged

Add a notification component #1313

merged 3 commits into from
Oct 6, 2024

Conversation

violetadev
Copy link
Contributor

@violetadev violetadev commented Sep 21, 2024

✨ Pull Request

📓 Referenced Issue

This is a notification component that is being added under the "..." menu on the toolbar.
The idea is that we have a space to add important information, in this case I have added a version check, to let the user know when there is a new version available (I noticed a lot of users asking about the new features or bug fixes). This checks every 2 weeks for a new version on github.

There are two parts of this PR; the notification system, with its own hook and UI and the version check with its own hook.

Tech Design

responsively-app drawio

Notification UI

Screen.Recording.2024-09-21.at.13.21.20.mov

Empty State

Screenshot 2024-09-21 at 14 24 17

ℹ️ About the PR

🖼️ Testing Scenarios / Screenshots

To test this, you will need to have an older version of the app, in order to see the notification for the new app download message.

@violetadev violetadev marked this pull request as ready for review September 21, 2024 13:15
@manojVivek
Copy link
Collaborator

@violetadev Apologies for the delay, this looks good overall, but the only concern is that it would be great if we could leverage the native app updater into the workflow instead of taking the users to the website.

Here's the reference code to the app updater: https://github.com/responsively-org/responsively-app/blob/main/desktop-app/src/main/main.ts#L242C9-L242C19

We also use it in the help menu to show the update status like this:
Screenshot 2024-09-23 at 11 30 19 AM

So I believe it makes more sense to unify the app update workflow to eliminate any confusion to the users. Wdyt?

One slight disadvantage I can see with this approach: I'm not 100% certain if the native app update works well on Windows, as we don't have the app binary signed. In that case, the CTA in the notification might not do anything useful. But saying this only because I have personally not validated the native app update on Windows, it could be working fine as well. 🤷🏼‍♂️

@violetadev
Copy link
Contributor Author

@manojVivek 100%! I was thinking of trying to do this on a different pull request but seeing we have something already I’ll add it here. I have windows and mac, so I can try it out in both :D

@violetadev
Copy link
Contributor Author

violetadev commented Sep 24, 2024

@manojVivek I'm going to open a second PR with the update notification, so this PR doesn't go stale and it's not so big to review. I removed the notification with the download link to the website. Now it's just the notification system. Do you approve?

@manojVivek
Copy link
Collaborator

@manojVivek I'm going to open a second PR with the update notification, so this PR doesn't go stale and it's not so big to review. I removed the notification with the download link to the website. Now it's just the notification system. Do you approve?

Yes, sounds good!

You can stack the PR with those changes on top of this PR and merge it altogether once everything is ready, whichever works for you.

Copy link
Collaborator

@manojVivek manojVivek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm!

@violetadev violetadev merged commit 080b2e2 into main Oct 6, 2024
5 checks passed
@violetadev violetadev deleted the update-button branch October 6, 2024 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants