-
Notifications
You must be signed in to change notification settings - Fork 20
bump minimum supported python version to 3.11 (released 2021) #219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
|
I tested numpy v2+ locally and it works fine, i don't think we need to pin it to <2.0 anymore now that I'll rebase this branch after @PaulDudaRESPEC merges #218 and the tests should then all pass -- they're failing on pandas 3.0. edit: realized i should just let #218 include the dependency change for numpy too. That way tests can run and see if it works. I reverted this branch to be solely about python support. |
fc777b9 to
6696601
Compare
|
Personally I think we should allow the |
|
The suggestion is to pin the project to >=3.11 not 3.12, and to stop testing on super old versions of Python. |
|
It only causes debugging time in theory in some future and in reality the fact that we had 3.9&3.10 in the mix here allowed us to find the issues with pandas 3.0.0 because 3.9/10 installs only had <3.0.0 -- it literally was the path forward to debugging it. |
I think you're underestimating yourself. I'm sure you would have been able to determine that the issue was caused by a pandas release even without running tests on 3.9. Especially since we have tests on 3.11 with a variety of pandas versions (some worked some did not) and since tests run earlier in the week with the same code passed just fine. This happens all the time with dependencies releasing major versions. I also believe that the debugging effort is not just a theory (see #220), and I'd like to invite others into this conversation about how to proceed given the following:
Additionally, the project would likely continue to work fine on 3.9&3.10 for quite some time, we just wouldn't bother our developer community with issues about those versions any more. |
I have two responses to this concept:
Finally I think the goals of moving towards code that is compatible with updates to numpy or numba are great, and I think that in the interest of everyone's time it is best to organically move this direction rather than cutting off working versions. |
We currently support a lot of very old versions of python, especially related to our primary dependencies.
https://scientific-python.org/specs/spec-0000/
python 3.11 is not longer supported by python, but it's still supported by our major dependencies:
numba minimum python version is 3.10, 3.11 preferred
numpy minimum python version is 3.11
dropping support for python <3.10 will let us plan for the future, and start take advantage of tests that run with the 'jit' compiler in 3.14. This will also help us transition to pandas 3.x and numpy 2.x (we currently pin to numpy < 2 but v1 is no longer supported).
@rburghol @PaulDudaRESPEC @aufdenkampe @timcera Any objection to working toward modernizing? Keep in mind that old pypi versions will still work on old pythons.