Skip to content

Conversation

@benabineri
Copy link
Contributor

Description of change

This is somewhat speculative but I was dismayed by this:

resim --auth-url=https://resim-dev.us.auth0.com/ --url=https://api.resim.io/v1/ --project image-testing systems get --id 8ecf89d8-56b0-46da-8e67-46dd1f04c6d9 
2025/08/15 14:15:57 unknown flag: --id
resim --auth-url=https://resim-dev.us.auth0.com/ --url=https://api.resim.io/v1/ --project image-testing systems get --system-id 8ecf89d8-56b0-46da-8e67-46dd1f04c6d9
2025/08/15 14:16:03 unknown flag: --system-id
resim --auth-url=https://resim-dev.us.auth0.com/ --url=https://api.resim.io/v1/ --project image-testing systems get --system 8ecf89d8-56b0-46da-8e67-46dd1f04c6d9 
<the system>

This change makes them all work.

Guide to reproduce test results

Checklist

  • I have self-reviewed this change.
  • I have tested this change.
  • This change is covered by tests that are already landed, or in this PR.
  • I have updated the changelog, if appropriate.

@benabineri benabineri changed the base branch from main to iain/support-arm August 15, 2025 14:43
@benabineri benabineri changed the title Ben/id flags normalise ID flags Aug 15, 2025
Base automatically changed from iain/support-arm to main August 22, 2025 17:27
}

// Support --<component> and --id as aliases for --<component>-id for known components
knownComponents := []string{"batch", "report", "sweep", "build", "test", "branch", "system"}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i don't think we can be so general about this and have it work completely correctly (partly due to issues with our current implementations).

For example, most places where we have batch it's either batch-name or batch-id explicitly. For builds, it's only ever build-id. I think for this to work for those, we'd need to make some further changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants