feat: add optional baseUrl and userAgent to Resend constructor#839
Open
xiaoyu2er wants to merge 1 commit intoresend:canaryfrom
Open
feat: add optional baseUrl and userAgent to Resend constructor#839xiaoyu2er wants to merge 1 commit intoresend:canaryfrom
xiaoyu2er wants to merge 1 commit intoresend:canaryfrom
Conversation
- Add ResendOptions interface with optional baseUrl and userAgent - Use instance properties this.baseUrl and this.userAgent (env/options fallback) - Export ResendOptions from index - Add resend.spec.ts with tests for options and env override Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
could you take a look @cassiozen @gabrielmfern 🙏 |
commit: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add optional
optionsto the Resend constructor so callers can overridebaseUrlanduserAgentwhile keeping the existing default/env behavior.Changes
baseUrl?: stringanduserAgent?: string.new Resend(key?, options?)— whenoptions.baseUrl/options.userAgentare provided, they override env and defaults.resend.baseUrlandresend.userAgent(readonly) used for requests and headers.getDefaultBaseUrl()andgetDefaultUserAgent()(envRESEND_BASE_URL/RESEND_USER_AGENTthen fallbacks).ResendOptionsexported from the package entry.Usage
Tests
src/resend.spec.ts: 10 tests for default values, options override, env override, and that requests use custom baseUrl and User-Agent.Summary by cubic
Adds optional options to the Resend constructor to set baseUrl and User-Agent per instance. Keeps env/default fallback and uses these values in request URLs and headers.
Written for commit dd83549. Summary will update on new commits.