Conversation
commit: |
9ebfd47 to
0102507
Compare
0102507 to
e97187d
Compare
Contributor
There was a problem hiding this comment.
2 issues found across 10 files
Prompt for AI agents (all 2 issues)
Understand the root cause of the following 2 issues and fix them.
<file name="src/contact-properties/interfaces/create-contact-property-options.interface.ts">
<violation number="1" location="src/contact-properties/interfaces/create-contact-property-options.interface.ts:20">
CreateContactPropertyApiOptions should preserve the correlation between type and fallback_value; the current union allows number properties to carry string fallbacks (and vice versa), leading to invalid API payloads.</violation>
</file>
<file name="src/common/utils/parse-contact-properties-to-api-options.ts">
<violation number="1" location="src/common/utils/parse-contact-properties-to-api-options.ts:21">
parseContactPropertyToApi coerces an object missing id/object/created_at into ApiContactProperty, so any caller receives an incomplete API payload. Please include the required fields when converting.</violation>
</file>
React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.
src/contact-properties/interfaces/create-contact-property-options.interface.ts
Show resolved
Hide resolved
8d1b54c to
805fb4a
Compare
vcapretz
approved these changes
Oct 22, 2025
cassiozen
approved these changes
Oct 22, 2025
lucasfcosta
pushed a commit
that referenced
this pull request
Oct 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by cubic
Adds SDK support for managing contact properties with create, list, get, update, and delete methods. Normalizes API snake_case to SDK camelCase and provides type-safe request/response interfaces.