Open
Conversation
…hey pass without errors
drish
reviewed
Jan 5, 2026
| @@ -1,4 +1,4 @@ | |||
| FROM golang:1.23 | |||
| FROM golang:1.25 | |||
drish
reviewed
Jan 5, 2026
| module github.com/resend/resend-go/v3 | ||
|
|
||
| go 1.23 | ||
| go 1.25.5 |
Collaborator
There was a problem hiding this comment.
Since 1.24 and 1.25 are the latest two stable versions, we will need to have the minimum stable version (1.24) here in the go.mod file, and keep 1.25 as part of our testing matrix, this way we make sure we're properly supporting both latest stables.
Collaborator
|
hey @matoszz, thanks for the contribution again! left one comment related to the version on the mod file, the other changes are good. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not 100% sure if you can have a matrix-based pipeline testing a downgraded version (vs. having a go.mod with 1.24 and testing up to 1.25) but giving it a try!
The other changes in this PR:
non-constant format string in call to fmt.Fprintf, so the statements were changed to simplyfmt.Fprintlen() > 0becauselen()for nil maps is defined as zero (so the check was redundant)Summary by cubic
Upgrade project to Go 1.25.5, update CI to test Go 1.24 and 1.25, and align Docker and dependencies. Also fix test warnings and a malformed struct tag.
Dependencies
Bug Fixes
Written for commit 22707e5. Summary will update automatically on new commits.