-
Notifications
You must be signed in to change notification settings - Fork 866
fix(react-email): broken hot reloading with non-js imports #2572
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: a4b87b9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No issues found across 2 files
Closes #2378.
I've tested this on a reproduction similar to what #2378 provides, and it worked after this change on the preview version from pkg.pr.new/
Summary by cubic
Fixes broken hot reloading for imports with non-JS extensions by correcting dependency path resolution in the preview hot-reloading graph. Explicit extensions are now respected, so CSS and image imports reload as expected.