Skip to content

Conversation

@zehfernandes
Copy link
Contributor

@zehfernandes zehfernandes commented Oct 9, 2025


Summary by cubic

Standardized component images to JPEG and cleaned up WebGL code for the hero tower. This removes unused assets, simplifies imports, and keeps the collage rendering working with the new images.

  • Refactors
    • Replaced /static/components/*.png with *.jpeg and removed banner.jpg.
    • Removed Banner component and webgl index; deleted data/images.ts.
    • Moved WebGL files to src/webgl; made Billboard a named export.
    • Updated imports in hero.tsx and useCollageTexture to new paths.
    • Inlined IMAGES array in tower and wired it to useCollageTexture.

@changeset-bot
Copy link

changeset-bot bot commented Oct 9, 2025

⚠️ No Changeset found

Latest commit: 50eef1b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 9, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
react-email Ready Ready Preview Comment Oct 9, 2025 4:14pm
react-email-demo Ready Ready Preview Comment Oct 9, 2025 4:14pm

Copy link
Contributor

@cubic-dev-ai cubic-dev-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 issue found across 26 files

Prompt for AI agents (all 1 issues)

Understand the root cause of the following 1 issues and fix them.


<file name="apps/web/src/webgl/tower.tsx">

<violation number="1" location="apps/web/src/webgl/tower.tsx:13">
Rule violated: **Initialisms and Acronyms Naming Conventions**

Please rename the `IMAGES` constant to camelCase/PascalCase so it does not use an all-uppercase acronym, per the Initialisms and Acronyms Naming Conventions guideline.</violation>
</file>

React with 👍 or 👎 to teach cubic. Mention @cubic-dev-ai to give feedback, ask questions, or re-run the review.

@zehfernandes zehfernandes merged commit 88205c9 into canary Oct 9, 2025
14 checks passed
@zehfernandes zehfernandes deleted the feat/clean-up-and-images branch October 9, 2025 16:18
@emiliosheinz
Copy link
Contributor

I love how the new images are way smaller :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants