fix: data-source-* attributes in HTML code view #2444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gabrielmfern
requested review from
CarolinaMoraes
and removed request for
a team
🦋 Changeset detectedLatest commit: 79bb589 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
gabrielmfern
requested review from
a team and
pedro-stramantinoli
and removed request for
a team and
CarolinaMoraes
commit: |
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
pedro-stramantinoli
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For background, we use a custom JSX runtime that, if there is a certain boolean as true in the
globalThis, it then adds indata-source-*properties pointing to the filename and line of the HTML element. We render multiple times, once with this just to be able to interpolate where errors happen, and another time without.The issues were being caused by the fact that we were rendering in “parallel” with
Promise.all, which made that global value be enabled when it shouldn't. To fix this I've just changed it to not usePromise.all, which didn't have as much of a performance impact as I expected.Summary by cubic
Fixes data-source-* attributes incorrectly appearing in the HTML code view by running email renders sequentially. This avoids the global JSX flag leaking across parallel renders.