-
Notifications
You must be signed in to change notification settings - Fork 844
feat(render): Add useRenderingOptions #1926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@thena-seer is attempting to deploy a commit to the resend Team on Vercel. A member of the Team first needs to authorize it. |
391afdd to
8a7d9d0
Compare
|
a5ebbe7 to
d103e29
Compare
d103e29 to
71c55b7
Compare
| @@ -0,0 +1,26 @@ | |||
| import { Options } from "./options"; | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was thinking about this and I got to the conclusion that the uniqueRenderId would end up being used more often than not, and its ergonomic are not great for common use cases. If you can think of anything that would just work out-of-the-box like useContext lmk.
Let's use a context for now and in the future we'll think about how to make it work with react-markup.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, switched back to useContext
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Although, I'm not sure how to resolve the rsnd build error we're seeing in CI.
…1749) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: gabriel miranda <gabrielmfern@outlook.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Bu Kinoshita <6929565+bukinoshita@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: gabriel miranda <gabrielmfern@outlook.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
e86e571 to
d5fdaa5
Compare
be584c9 to
0ab0f29
Compare
ae17b61 to
e62d722
Compare
2eba90b to
98c3d9b
Compare
0074ddf to
f7e553f
Compare
61d045a to
cee3eec
Compare
addf436 to
ade5f69
Compare
3ff8597 to
3c4ea0a
Compare
|
Sorry for taking so long, but I don't think we're going to be able to support it, sadly. For this to be supported, and we'd love to have it, we'd need to rethink how this gets implemented at the core, open to any ideas if anyone has some. But using a context isn't going to be sustainable, and already breaks in our |
Summary
For feature request #686 (comment)
Adds useRenderingOptions, which uses a React Context under the hood to pass the rendering options to the template.
Usage:
Test plan
unit tests pass