Skip to content

Update basic_usage.md #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Feb 18, 2018
Merged

Update basic_usage.md #22

merged 5 commits into from
Feb 18, 2018

Conversation

thangngoc89
Copy link
Contributor

No description provided.

@fakenickels
Copy link
Member

Thanks for the PR! I'm going to check why the build is failing, I think the script I made does not cover the proper case

@@ -12,7 +12,7 @@ module SignUpFormParams = {
/* Define the form state */
type state = {
password: string,
confirmP: string,
   confirmP: string,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch!, but I think it is confirmPassword

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes. I think Github is not on my side today :'( . I typed confirmPassword but it kept saving it as confirmP

@thangngoc89
Copy link
Contributor Author

Alright. I updated the basic usage page. it should work now

Copy link
Member

@fakenickels fakenickels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks!

@fakenickels fakenickels merged commit cb9d3d8 into rescriptbr:master Feb 18, 2018
@thangngoc89 thangngoc89 deleted the patch-1 branch February 19, 2018 04:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants