Skip to content

Proposal: Rewrite with untagged variants #62

Open
Open
Proposal: Rewrite with untagged variants#62

Description

@mununki
mununki
opened on Jul 13, 2023

Proposal

Rewriting the bindings by the polymorphic variant using the untagged variant in ReScript v11. e.g. https://github.com/rescript-react-native/rescript-react-navigation/blob/main/src/NativeStack.res#L9-L19

Benefit

Using variant versus polymorphic variant gives us more information at compile time, and is more idiomatic.

Activity

  1. cknitt commented on Jul 19, 2023

    @cknitt
    cknitt
    on Jul 19, 2023
    Member

    With all the new features regarding variants in ReScript 11, I agree that normal variants should be preferred over polymorphic variants for writing new bindings. This was also our philosophy in the new rescript-mui bindings where we make heavy use of untagged variants.

    OTOH, for the case of rescript-react-navigation,

    • this would mean breaking changes with little visible benefits to the user
    • it is not just rescript-react-navigation but also rescript-react-native itself that currently prefers polymorphic variants, and we should probably remain consistent with it.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions