Skip to content
This repository was archived by the owner on Jun 15, 2023. It is now read-only.

Conversation

@mununki
Copy link
Member

@mununki mununki commented Sep 27, 2022

about not adding @rescript/react into v3-deps

- about not adding `@rescript/react` into v3-deps
cli/JSXV4.md Outdated

In V3 compatibility mode, the listed dependencies are built in V3 mode, and in addition `-open ReatcV3` is added to the compiler options, so that the `ReactV3` compatibility module in rescript-react is used.

> Note that `@rescript/react` is not necessary adding in the `v3-dependencies`, or it would make the cyclic dependencies error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: do not add @rescript/reactin the v3-dependencies, or it will cause a cyclic dependencies error.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! eb89eb0

@cristianoc cristianoc merged commit e3dcc3f into master Sep 27, 2022
@cristianoc cristianoc deleted the jsx-v4-doc-v3-deps branch September 27, 2022 02:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants