This repository was archived by the owner on Jun 15, 2023. It is now read-only.
Re-enable the ability for users to define custom operators #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's huge!! Thank you @IwanKaramazow 😄 |
cristianoc
reviewed
Feb 18, 2021
| let isMultiplicationLikeOperator operator = | ||
| String.length operator > 0 && ( | ||
| let firstChar = String.unsafe_get operator 0 in | ||
| firstChar == '*' || firstChar == '/' || firstChar == '%' |
There was a problem hiding this comment.
Nit: operators such as ** are both exponentiation and multiplication at the moment.
|
The rescript-lang/syntax repo is obsolete and will be archived soon. If this issue is still relevant, please reopen in the compiler repo (https://github.com/rescript-lang/rescript-compiler) or comment here to ask for it to be moved. Thank you for your contributions. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://rescript-lang.org/blog/editor-support-custom-operators-and-more#custom-operators