Add prepareRename command #7847
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
prepareRenamecommand to the analysis bin that the editor tooling can use to get quick feedback for whether the target thing can be renamed or not.Background for this is that our current rename functionality feels slow, and that's because it does all the heavy lifting of figuring out all places a rename needs to be applied, plus producing the actual text edits, twice - once to simply check if something can be renamed, and then again to do the actual rename. The command added in this PR replaces the first with a light weight super fast command that only looks at the untyped AST.
Will need adjustments in the editor tooling repo too for this to actually work.